Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24552 )
Change subject: IMPALA-15165: Add minimal C++ WKB serialization support ...................................................................... Patch Set 9: (2 comments) Made tests more compact, added a few new ones and refactored bbox checking. I no longer consider the change WIP http://gerrit.cloudera.org:8080/#/c/24552/6/be/src/exprs/geo/wkb-serialization.cc File be/src/exprs/geo/wkb-serialization.cc: http://gerrit.cloudera.org:8080/#/c/24552/6/be/src/exprs/geo/wkb-serialization.cc@272 PS6, Line 272: polygon2d poly; : poly.outer().reserve(5); : // CW order: matches polygon2d convention (bg::model::polygon<…, ClockWise=true>). : poly.outer().emplace_back(xmin, ymin); : poly.outer().emplace_back(xmin, ymax); > Is there a reason for this being counter-clockwise? Good point, reversed it an added dcheck. This probably didn't matter because both c++ and java implementation handle wrong orientations http://gerrit.cloudera.org:8080/#/c/24552/6/be/src/exprs/geo/wkb-serialization.cc@300 PS6, Line 300: mplate <bool SWAP> > This is not an empty box, this is a box containing the point (0, 0). good point, update to a bbox like that -- To view, visit http://gerrit.cloudera.org:8080/24552 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d5b2ac5d584e3de7712d8471acbc07d743a4de2 Gerrit-Change-Number: 24552 Gerrit-PatchSet: 9 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 16 Jul 2026 18:52:53 +0000 Gerrit-HasComments: Yes
