Balazs Hevele has posted comments on this change. ( http://gerrit.cloudera.org:8080/24540 )
Change subject: POC IMPALA-15164: Port native C++ geospatial functions to WKB mode ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/24540/8/be/src/exprs/geo/relation-wrapper-wkb-test.cc File be/src/exprs/geo/relation-wrapper-wkb-test.cc: http://gerrit.cloudera.org:8080/#/c/24540/8/be/src/exprs/geo/relation-wrapper-wkb-test.cc@33 PS8, Line 33: static polygon2d MakeSquare(double x0, double y0, double x1, double y1) { : polygon2d poly; : bg::append(poly.outer(), P(x0, y0)); : bg::append(poly.outer(), P(x1, y0)); : bg::append(poly.outer(), P(x1, y1)); : bg::append(poly.outer(), P(x0, y1)); : bg::append(poly.outer(), P(x0, y0)); : bg::correct(poly); : return poly; : } Shouldn't it be wound clockwise (assuming x1 > x0 and y1 > y0)? Also, a rectangle, not a square. -- To view, visit http://gerrit.cloudera.org:8080/24540 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0047acebd4aaa774bf6bb8ec0618515d38ad6aae Gerrit-Change-Number: 24540 Gerrit-PatchSet: 8 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 15 Jul 2026 10:26:04 +0000 Gerrit-HasComments: Yes
