Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/24049 )
Change subject: IMPALA-14805: Allow loading Iceberg file list in coordinator ...................................................................... Patch Set 18: Code-Review+1 (1 comment) Thanks for implementing this! I think coordinator-only loading is the good direction for Iceberg tables - but we might need to do some refactoring in the future. http://gerrit.cloudera.org:8080/#/c/24049/18/fe/src/main/java/org/apache/impala/catalog/local/IcebergMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/IcebergMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/24049/18/fe/src/main/java/org/apache/impala/catalog/local/IcebergMetaProvider.java@598 PS18, Line 598: IcebergFileMetadataLoader iceFml = new IcebergFileMetadataLoader( : apiTable, oldFiles, hostIndex, groupedFiles, oldPartitions, false, null); This will always be a full load without optimization, e.g. incremental load. This could be a regression compared to the catalog loading. Do you plan to add incremental load later? -- To view, visit http://gerrit.cloudera.org:8080/24049 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6732af76a2e040fa57e39260302951466037b934 Gerrit-Change-Number: 24049 Gerrit-PatchSet: 18 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 15 Jul 2026 14:43:30 +0000 Gerrit-HasComments: Yes
