Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24049 )
Change subject: IMPALA-14805: Allow loading Iceberg file list in coordinator ...................................................................... Patch Set 18: (6 comments) http://gerrit.cloudera.org:8080/#/c/24049/18/be/src/util/backend-gflag-util.cc File be/src/util/backend-gflag-util.cc: http://gerrit.cloudera.org:8080/#/c/24049/18/be/src/util/backend-gflag-util.cc@332 PS18, Line 332: "are loaded locally instead of requesting from the catalogd."); nit: Let's mention whether this should be set in catalogd. http://gerrit.cloudera.org:8080/#/c/24049/17/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/24049/17/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@1397 PS17, Line 1397: // catalog version, most files are probably still reusable and the next "fresh" > line too long (93 > 90) Please resolve these long lines http://gerrit.cloudera.org:8080/#/c/24049/18/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/24049/18/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@1363 PS18, Line 1363: TABLE_METADATA_CACHE_CATEGORY Can we use a new category? This is currently used for fetching hmsTable and apiTable from catalogd. It's also used in fetching IcebergContentFileStore from catalogd when the flag is false. But I think that should also use a new category, e.g. ICEBERG_FILE_METADATA_CACHE_CATEGORY = "IcebergFiles". With a new category we can add tests verifying this code path is exercised. It also improves diagnostics. http://gerrit.cloudera.org:8080/#/c/24049/18/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@1399 PS18, Line 1399: WeakReference nit: WeakReference<> http://gerrit.cloudera.org:8080/#/c/24049/18/fe/src/main/java/org/apache/impala/catalog/local/IcebergMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/IcebergMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/24049/18/fe/src/main/java/org/apache/impala/catalog/local/IcebergMetaProvider.java@598 PS18, Line 598: IcebergFileMetadataLoader iceFml = new IcebergFileMetadataLoader( : apiTable, oldFiles, hostIndex, groupedFiles, oldPartitions, false, null); > This will always be a full load without optimization, e.g. incremental load Does it mean we can load files with predicates from the query that triggers the load? http://gerrit.cloudera.org:8080/#/c/24049/18/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/24049/18/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7946 PS18, Line 7946: FeFsPartition partition, nit: merge this with the previous line -- To view, visit http://gerrit.cloudera.org:8080/24049 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6732af76a2e040fa57e39260302951466037b934 Gerrit-Change-Number: 24049 Gerrit-PatchSet: 18 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 17 Jul 2026 05:41:21 +0000 Gerrit-HasComments: Yes
