Aman Sinha has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24528 )

Change subject: IMPALA-15135: Calcite planner: added support for Kudu tables
......................................................................


Patch Set 16: Code-Review+1

(3 comments)

+1 from my side.  Will wait in case Michael wants to do another pass.

http://gerrit.cloudera.org:8080/#/c/24528/12/testdata/workloads/functional-query/queries/QueryTest/kudu_runtime_filter_with_timestamp_conversion.test
File 
testdata/workloads/functional-query/queries/QueryTest/kudu_runtime_filter_with_timestamp_conversion.test:

http://gerrit.cloudera.org:8080/#/c/24528/12/testdata/workloads/functional-query/queries/QueryTest/kudu_runtime_filter_with_timestamp_conversion.test@30
PS12, Line 30: .*.ts
> I thought I had done it before, but I couldn't find it.
Done


http://gerrit.cloudera.org:8080/#/c/24528/13/testdata/workloads/functional-query/queries/QueryTest/kudu_runtime_filter_with_timestamp_conversion.test
File 
testdata/workloads/functional-query/queries/QueryTest/kudu_runtime_filter_with_timestamp_conversion.test:

http://gerrit.cloudera.org:8080/#/c/24528/13/testdata/workloads/functional-query/queries/QueryTest/kudu_runtime_filter_with_timestamp_conversion.test@30
PS13, Line 30: .*.ts
> This was an accidental rollback from patch 12 to patch 13.  It fails with t
Done


http://gerrit.cloudera.org:8080/#/c/24528/12/testdata/workloads/functional-query/queries/QueryTest/partitioned-top-n-high-ndv.test
File 
testdata/workloads/functional-query/queries/QueryTest/partitioned-top-n-high-ndv.test:

http://gerrit.cloudera.org:8080/#/c/24528/12/testdata/workloads/functional-query/queries/QueryTest/partitioned-top-n-high-ndv.test@39
PS12, Line 39: row_regex:'|  partition by: .*part1, .*part2, .*part3, .*col4, 
.*col5'
> ack
Done



--
To view, visit http://gerrit.cloudera.org:8080/24528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie22a66f0edad195cade74a8447efc83a8ce526f7
Gerrit-Change-Number: 24528
Gerrit-PatchSet: 16
Gerrit-Owner: Steve Carlin <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
Gerrit-Reviewer: Xuebin Su <[email protected]>
Gerrit-Comment-Date: Wed, 15 Jul 2026 17:12:18 +0000
Gerrit-HasComments: Yes

Reply via email to