Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24588 )

Change subject: IMPALA-15117: Optimize getFirstLevelAcidDirPath
......................................................................


Patch Set 2:

(1 comment)

Thanks for the patch! I've added a few others to help review.

http://gerrit.cloudera.org:8080/#/c/24588/2/fe/src/main/java/org/apache/impala/util/AcidUtils.java
File fe/src/main/java/org/apache/impala/util/AcidUtils.java:

http://gerrit.cloudera.org:8080/#/c/24588/2/fe/src/main/java/org/apache/impala/util/AcidUtils.java@24
PS2, Line 24: import java.io.IOException;
> unused import: java.io.IOException
These aren't caused by your patch but would be nice to cleanup. We have a new 
job to detect unused imports that only flags files when they're changed.



--
To view, visit http://gerrit.cloudera.org:8080/24588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I390183039181bb62d6818c8e869738ddf01c2f6b
Gerrit-Change-Number: 24588
Gerrit-PatchSet: 2
Gerrit-Owner: Jiyoung Yoo <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
Gerrit-Comment-Date: Wed, 15 Jul 2026 18:36:15 +0000
Gerrit-HasComments: Yes

Reply via email to