Jiyoung Yoo has posted comments on this change. ( http://gerrit.cloudera.org:8080/24588 )
Change subject: IMPALA-15117: Optimize getFirstLevelAcidDirPath ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/24588/2/fe/src/main/java/org/apache/impala/util/AcidUtils.java File fe/src/main/java/org/apache/impala/util/AcidUtils.java: http://gerrit.cloudera.org:8080/#/c/24588/2/fe/src/main/java/org/apache/impala/util/AcidUtils.java@24 PS2, Line 24: import java.io.IOException; > These aren't caused by your patch but would be nice to cleanup. We have a n Done http://gerrit.cloudera.org:8080/#/c/24588/2/fe/src/main/java/org/apache/impala/util/AcidUtils.java@38 PS2, Line 38: import org.apache.hadoop.fs.FileSystem; > unused import: org.apache.hadoop.fs.FileSystem Done http://gerrit.cloudera.org:8080/#/c/24588/2/fe/src/main/java/org/apache/impala/util/AcidUtils.java@214 PS2, Line 214: return acidRoot.getName() + parentStr.substring(rootStr.length()); > Can you add a comment describing this branch? I don't understand why it's n You are right, we don't need to compare parentStr and rootStr because they always shares the same prefix. I added some comments with the fix. Thanks! -- To view, visit http://gerrit.cloudera.org:8080/24588 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I390183039181bb62d6818c8e869738ddf01c2f6b Gerrit-Change-Number: 24588 Gerrit-PatchSet: 2 Gerrit-Owner: Jiyoung Yoo <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jiyoung Yoo <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 15 Jul 2026 21:34:58 +0000 Gerrit-HasComments: Yes
