Daniel Vanko has posted comments on this change. (
http://gerrit.cloudera.org:8080/24585 )
Change subject: IMPALA-5961: Read generated TPC-DS test data as ISO-8859-1
......................................................................
Patch Set 2:
(2 comments)
> Patch Set 2: Code-Review+1
>
> lgtm, but I am curious about other reviewer's opinion about re-encoding
> during dataload vs setting it for tables
Thanks, although I'm not so sure about if the ALTER TABLE ... SET
SERDEPROPERTIES('serialization.encoding'='ISO-8859-1') statements being on the
beginning of LOAD section is semantically correct. README mentions an ALTER
session as well, I'm checking if that can be used.
http://gerrit.cloudera.org:8080/#/c/24585/1/testdata/datasets/tpcds/preload
File testdata/datasets/tpcds/preload:
http://gerrit.cloudera.org:8080/#/c/24585/1/testdata/datasets/tpcds/preload@116
PS1, Line 116:
> Did you check how much time this step takes?
On my desktop it took about 2-3 seconds (3-5% of the whole preload script).
http://gerrit.cloudera.org:8080/#/c/24585/1/testdata/datasets/tpcds/preload@117
PS1, Line 117: tables=("call_center" "catalog_page" "catalog_returns"
"catalog_sales" "customer"
: "customer_address" "customer_demographics" "date_dim"
"dbgen_version"
: "household_demographics" "income_band" "inventory"
"item" "promotion"
: "reason" "ship_mode" "store" "store_returns"
"store_sales" "time_dim"
: "warehouse" "web_page" "web_returns" "web_sales"
"web_site")
:
: # Verify that all the expected files exist. Impala expects each
table to be in its
: # ow
> An alternative would be do the conversion when reading with Impala.
Done
--
To view, visit http://gerrit.cloudera.org:8080/24585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic72dd4ad641083c22e8759160251b620e9da605c
Gerrit-Change-Number: 24585
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Vanko <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Daniel Vanko <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Mihaly Szjatinya <[email protected]>
Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]>
Gerrit-Comment-Date: Thu, 16 Jul 2026 16:15:20 +0000
Gerrit-HasComments: Yes
