Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24585 )
Change subject: IMPALA-5961: Read generated TPC-DS test data as ISO-8859-1 ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/24585/3/testdata/datasets/tpcds/tpcds_schema_template.sql File testdata/datasets/tpcds/tpcds_schema_template.sql: http://gerrit.cloudera.org:8080/#/c/24585/3/testdata/datasets/tpcds/tpcds_schema_template.sql@44 PS3, Line 44: ALTER TABLE {db_name}{db_suffix}.{table_name} SET SERDEPROPERTIES('serialization.encoding'='ISO-8859-1'); It would be nicer to have a ---- SERDE_PROPERTIES section, but there are many things to clean up about these schema template files, this looks like just a minor improvement. -- To view, visit http://gerrit.cloudera.org:8080/24585 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic72dd4ad641083c22e8759160251b620e9da605c Gerrit-Change-Number: 24585 Gerrit-PatchSet: 3 Gerrit-Owner: Daniel Vanko <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Comment-Date: Wed, 22 Jul 2026 14:34:10 +0000 Gerrit-HasComments: Yes
