Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/24588 )
Change subject: IMPALA-15117: Optimize getFirstLevelAcidDirPath ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/24588/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24588/4//COMMIT_MSG@29 PS4, Line 29: Testing: AcidUtilsTest.testGetFirstLevelAcidDirPath Did this run against the core tests? If yes, we can mention here in the "Testing" section http://gerrit.cloudera.org:8080/#/c/24588/4/fe/src/main/java/org/apache/impala/util/AcidUtils.java File fe/src/main/java/org/apache/impala/util/AcidUtils.java: http://gerrit.cloudera.org:8080/#/c/24588/4/fe/src/main/java/org/apache/impala/util/AcidUtils.java@180 PS4, Line 180: but has been refactored to : * eliminate costly HDFS PRC calls(e.g. FileSystem.isDirectory) It is mentioned in the commit message, but it's better to put it directly in the Javadoc to explain why we can safely remove the isDirectory call. "Since the input filePath is guaranteed to be a valid data file during metadata load" http://gerrit.cloudera.org:8080/#/c/24588/4/fe/src/main/java/org/apache/impala/util/AcidUtils.java@181 PS4, Line 181: PRC nit. RPC -- To view, visit http://gerrit.cloudera.org:8080/24588 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I390183039181bb62d6818c8e869738ddf01c2f6b Gerrit-Change-Number: 24588 Gerrit-PatchSet: 4 Gerrit-Owner: Jiyoung Yoo <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jiyoung Yoo <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Sat, 18 Jul 2026 03:46:01 +0000 Gerrit-HasComments: Yes
