Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/24166 )
Change subject: IMPALA-14684: Add metrics for catalogd table invalidations ...................................................................... Patch Set 7: (5 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/24166/5/common/thrift/metrics.json File common/thrift/metrics.json: http://gerrit.cloudera.org:8080/#/c/24166/5/common/thrift/metrics.json@670 PS5, Line 670: TIME > Let's use TIME_MS here (after changing the metric to be in milliseconds). Done http://gerrit.cloudera.org:8080/#/c/24166/5/fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java File fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java: http://gerrit.cloudera.org:8080/#/c/24166/5/fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java@107 PS5, Line 107: * ArrayDeque entries are ordered by timestamp and guarded by a lock so concurrent : * reads and cleanup from the daemon thread do not race. > ArrayList is also randomly accessible and supports binary search. Removed the comment and using an ArrayDeque now. http://gerrit.cloudera.org:8080/#/c/24166/5/fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java@255 PS5, Line 255: TTableName tTableName = tables.get(i).getTableName().toThrift(); > TIME_SOURCE.read() returns a time value representing the number of nanoseco Done http://gerrit.cloudera.org:8080/#/c/24166/5/fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java@260 PS5, Line 260: info("Table " + tables.get(i).getFullName() + " invalidated > These N items are added together and evicted together, which seems a waste. Done http://gerrit.cloudera.org:8080/#/c/24166/5/fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java@345 PS5, Line 345: /** > CopyOnWriteArrayList can't protect this from concurrent cleanup that shrink Thanks for the suggestion. Done. -- To view, visit http://gerrit.cloudera.org:8080/24166 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If78e6c8429801e3c1829860666f04ad287b826ab Gerrit-Change-Number: 24166 Gerrit-PatchSet: 7 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 20 Jul 2026 05:34:09 +0000 Gerrit-HasComments: Yes
