Nandor Kollar has posted comments on this change. ( http://gerrit.cloudera.org:8080/24166 )
Change subject: IMPALA-14684: Add metrics for catalogd table invalidations ...................................................................... Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/24166/8/fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java File fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java: http://gerrit.cloudera.org:8080/#/c/24166/8/fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java@110 PS8, Line 110: private static final class InvalidationBatch { nit: Probably record type could make this more concise? http://gerrit.cloudera.org:8080/#/c/24166/8/fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java@323 PS8, Line 323: private synchronized void recordInvalidationBatch(ArrayDeque<InvalidationBatch> batches, Since this method operates on the batches queue, it might be better to synchronize on batches instead of this. Is there a reason why modifications to ttlInvalidationBatches_ and memoryPressureInvalidationBatches_ need to be mutually exclusive? What do you think? http://gerrit.cloudera.org:8080/#/c/24166/8/fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java@352 PS8, Line 352: public static class InvalidationMetrics { nit: Probably record type could make this more concise? http://gerrit.cloudera.org:8080/#/c/24166/8/fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java@391 PS8, Line 391: public synchronized InvalidationMetrics getMetrics() { Since this method doesn't modify any state, would it make sense to use a read-write lock instead of synchronized? I think the backend calls this method periodically, so it's probably on a hot path, isn't it? -- To view, visit http://gerrit.cloudera.org:8080/24166 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If78e6c8429801e3c1829860666f04ad287b826ab Gerrit-Change-Number: 24166 Gerrit-PatchSet: 8 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Nandor Kollar <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 22 Jul 2026 14:40:21 +0000 Gerrit-HasComments: Yes
