Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24569 )

Change subject: IMPALA-2210: Make Parquet the default file format
......................................................................


Patch Set 2:

(9 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/24569/2/tests/metadata/test_ddl.py
File tests/metadata/test_ddl.py:

http://gerrit.cloudera.org:8080/#/c/24569/2/tests/metadata/test_ddl.py@913
PS2, Line 913: "
flake8: E501 line too long (91 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/24569/2/tests/metadata/test_explain.py
File tests/metadata/test_explain.py:

http://gerrit.cloudera.org:8080/#/c/24569/2/tests/metadata/test_explain.py@168
PS2, Line 168: E
flake8: E501 line too long (92 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/24569/2/tests/metadata/test_recover_partitions.py
File tests/metadata/test_recover_partitions.py:

http://gerrit.cloudera.org:8080/#/c/24569/2/tests/metadata/test_recover_partitions.py@76
PS2, Line 76: Q
flake8: E501 line too long (102 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/24569/2/tests/metadata/test_recover_partitions.py@141
PS2, Line 141: _
flake8: E501 line too long (100 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/24569/2/tests/metadata/test_recover_partitions.py@176
PS2, Line 176: A
flake8: E501 line too long (95 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/24569/2/tests/metadata/test_recover_partitions.py@220
PS2, Line 220: _
flake8: E501 line too long (100 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/24569/2/tests/metadata/test_recover_partitions.py@271
PS2, Line 271: _
flake8: E501 line too long (100 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/24569/2/tests/query_test/test_hdfs_caching.py
File tests/query_test/test_hdfs_caching.py:

http://gerrit.cloudera.org:8080/#/c/24569/2/tests/query_test/test_hdfs_caching.py@242
PS2, Line 242:
flake8: E501 line too long (94 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/24569/2/tests/query_test/test_hdfs_file_mods.py
File tests/query_test/test_hdfs_file_mods.py:

http://gerrit.cloudera.org:8080/#/c/24569/2/tests/query_test/test_hdfs_file_mods.py@60
PS2, Line 60: 1
flake8: E501 line too long (95 > 90 characters)



--
To view, visit http://gerrit.cloudera.org:8080/24569
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46a5d16dfd780aae41623ebfc9742dfbd2a596ea
Gerrit-Change-Number: 24569
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Rozsa <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Mon, 20 Jul 2026 12:55:14 +0000
Gerrit-HasComments: Yes

Reply via email to