Peter Rozsa has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24569 )

Change subject: IMPALA-2210: Make Parquet the default file format
......................................................................


Patch Set 5:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/24569/3/docs/topics/impala_default_file_format.xml
File docs/topics/impala_default_file_format.xml:

http://gerrit.cloudera.org:8080/#/c/24569/3/docs/topics/impala_default_file_format.xml@92
PS3, Line 92:       The default value was changed to <codeph>PARQUET</codeph> 
starting from
> We could add a note that default file format was changed to PARQUET startin
Done


http://gerrit.cloudera.org:8080/#/c/24569/3/docs/topics/impala_new_features.xml
File docs/topics/impala_new_features.xml:

http://gerrit.cloudera.org:8080/#/c/24569/3/docs/topics/impala_new_features.xml@551
PS3, Line 551: TEXT</c
> This is under the section of release 3.2, we should not touch that.
Done


http://gerrit.cloudera.org:8080/#/c/24569/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/24569/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@4640
PS3, Line 4640:       // Here, source table is a view which has no input 
format. So to be
              :       // consistent with CREATE TABLE, default input format is 
assumed to be
              :       // PARQUET unless otherwise specified.
              :       setStorageDescriptorFileFormat(tbl.getSd(), 
THdfsFileFormat.PARQUET);
> We ignore the DEFAULT_FILE_FORMAT query option here. This is a pre-existing
Done


http://gerrit.cloudera.org:8080/#/c/24569/3/tests/query_test/test_hdfs_file_mods.py
File tests/query_test/test_hdfs_file_mods.py:

http://gerrit.cloudera.org:8080/#/c/24569/3/tests/query_test/test_hdfs_file_mods.py@60
PS3, Line 60:         + "row format delimited fields terminated by \',\' 
location \'{1}\'"
            :     self.client.execute(create_table.format(uni
> What happens when ROW FORMAT DELIMITED is present without an explicit STORE
Done



--
To view, visit http://gerrit.cloudera.org:8080/24569
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46a5d16dfd780aae41623ebfc9742dfbd2a596ea
Gerrit-Change-Number: 24569
Gerrit-PatchSet: 5
Gerrit-Owner: Peter Rozsa <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Tue, 21 Jul 2026 15:29:47 +0000
Gerrit-HasComments: Yes

Reply via email to