Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/24363 )
Change subject: IMPALA-14981: Add operator reconciler packaging ...................................................................... Patch Set 37: (7 comments) http://gerrit.cloudera.org:8080/#/c/24363/37/operator/impala-operator/Dockerfile File operator/impala-operator/Dockerfile: http://gerrit.cloudera.org:8080/#/c/24363/37/operator/impala-operator/Dockerfile@18 PS37, Line 18: FROM python:3.11-slim Why Python 3.11 and not the latest 3.14.6-slim? http://gerrit.cloudera.org:8080/#/c/24363/37/operator/impala-operator/Dockerfile@44 PS37, Line 44: ENV DEFAULT_IMPALA_CHART_PATH=/charts/impala This ENV declaration should be somewhere above line 42 and all instances of the hardcoded string "/charts/impala" should use "${DEFAULT_IMPALA_CHART_PATH}" instead. http://gerrit.cloudera.org:8080/#/c/24363/37/operator/impala-operator/main.py File operator/impala-operator/main.py: http://gerrit.cloudera.org:8080/#/c/24363/37/operator/impala-operator/main.py@36 PS37, Line 36: /charts/impala/ Use the value of `DEFAULT_IMPALA_CHART_PATH` instead of the hardcoded string "/charts/impala". That way, if the default chart path is modified, DEFAULT_IMPALA_VALUES_FILE will not have to also be modified. http://gerrit.cloudera.org:8080/#/c/24363/37/operator/impala-operator/main.py@39 PS37, Line 39: /charts/impala Use the value of `DEFAULT_IMPALA_CHART_PATH` instead of the hardcoded string "/charts/impala". That way, if the default chart path is modified, DEFAULT_LDAP_VALUES_FILE will not have to also be modified. http://gerrit.cloudera.org:8080/#/c/24363/37/operator/impala-operator/main.py@48 PS37, Line 48: "api_key", No need to include since the only code that references _SENSITIVE_SET_KEY_PARTS removes underscores. http://gerrit.cloudera.org:8080/#/c/24363/37/operator/impala-operator/main.py@50 PS37, Line 50: "private_key", No need to include since the only code that references _SENSITIVE_SET_KEY_PARTS removes underscores. http://gerrit.cloudera.org:8080/#/c/24363/37/operator/impala-operator/main.py@89 PS37, Line 89: continue : safe.append(token) : idx += 1 This is a somewhat unexpected pattern. Use an `else:` clause instead of the `continue` keyword. -- To view, visit http://gerrit.cloudera.org:8080/24363 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b66e32b00724221ead2f4975802a26b2be7e248 Gerrit-Change-Number: 24363 Gerrit-PatchSet: 37 Gerrit-Owner: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Nandor Kollar <[email protected]> Gerrit-Comment-Date: Tue, 21 Jul 2026 21:39:33 +0000 Gerrit-HasComments: Yes
