Anubhav Jindal has posted comments on this change. ( http://gerrit.cloudera.org:8080/24363 )
Change subject: IMPALA-14981: Add operator reconciler packaging ...................................................................... Patch Set 38: (7 comments) Done http://gerrit.cloudera.org:8080/#/c/24363/37/operator/impala-operator/Dockerfile File operator/impala-operator/Dockerfile: http://gerrit.cloudera.org:8080/#/c/24363/37/operator/impala-operator/Dockerfile@18 PS37, Line 18: FROM python:3.14.6-slim > Why Python 3.11 and not the latest 3.14.6-slim? Thanks, updated base image to python:3.14.6-slim. http://gerrit.cloudera.org:8080/#/c/24363/37/operator/impala-operator/Dockerfile@44 PS37, Line 44: RUN pip install --no-cache-dir -r /app/requirements.txt > This ENV declaration should be somewhere above line 42 and all instances of Done. Moved ENV DEFAULT_* block above the chart copy and replaced hardcoded chart path usage with ${DEFAULT_IMPALA_CHART_PATH} http://gerrit.cloudera.org:8080/#/c/24363/37/operator/impala-operator/main.py File operator/impala-operator/main.py: http://gerrit.cloudera.org:8080/#/c/24363/37/operator/impala-operator/main.py@36 PS37, Line 36: "{DEFAULT_IMPAL > Use the value of `DEFAULT_IMPALA_CHART_PATH` instead of the hardcoded strin Done. DEFAULT_IMPALA_VALUES_FILEnow defaults to "{DEFAULT_IMPALA_CHART_PATH}/values-example.yaml" http://gerrit.cloudera.org:8080/#/c/24363/37/operator/impala-operator/main.py@39 PS37, Line 39: "{DEFAULT_IMPA > Use the value of `DEFAULT_IMPALA_CHART_PATH` instead of the hardcoded strin Done. DEFAULT_LDAP_VALUES_FILEnow defaults tof"{DEFAULT_IMPALA_CHART_PATH}/values-ldap-example.yaml" http://gerrit.cloudera.org:8080/#/c/24363/37/operator/impala-operator/main.py@48 PS37, Line 48: "privatekey", > No need to include since the only code that references _SENSITIVE_SET_KEY_P Agreed and removed redundant api_key http://gerrit.cloudera.org:8080/#/c/24363/37/operator/impala-operator/main.py@50 PS37, Line 50: "credential", > No need to include since the only code that references _SENSITIVE_SET_KEY_P Agreed and removed redundant private_key http://gerrit.cloudera.org:8080/#/c/24363/37/operator/impala-operator/main.py@89 PS37, Line 89: idx += 1 : return " ".join(safe) : > This is a somewhat unexpected pattern. Use an `else:` clause instead of th Done -- To view, visit http://gerrit.cloudera.org:8080/24363 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b66e32b00724221ead2f4975802a26b2be7e248 Gerrit-Change-Number: 24363 Gerrit-PatchSet: 38 Gerrit-Owner: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Nandor Kollar <[email protected]> Gerrit-Comment-Date: Tue, 21 Jul 2026 22:11:59 +0000 Gerrit-HasComments: Yes
