Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24576 )
Change subject: IMPALA-15174: Add AGGREGATED_PROFILE query option to toggle profile formats ...................................................................... Patch Set 2: (4 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24576/2/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: http://gerrit.cloudera.org:8080/#/c/24576/2/be/src/runtime/coordinator-backend-state.cc@573 PS2, Line 573: exec_params_.query_options().aggregated_profile ? nullptr : &*profile_iter, report_time_ms, line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/24576/2/be/src/runtime/coordinator-backend-state.cc@692 PS2, Line 692: if (finalize || instance_stats.done_ || exec_params_.query_options().aggregated_profile) { line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/24576/2/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/24576/2/be/src/service/impala-server.cc@1522 PS2, Line 1522: query_ctx->__set_gen_aggregated_profile(query_ctx->client_request.query_options.aggregated_profile); line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/24576/2/tests/custom_cluster/test_runtime_profile.py File tests/custom_cluster/test_runtime_profile.py: http://gerrit.cloudera.org:8080/#/c/24576/2/tests/custom_cluster/test_runtime_profile.py@35 PS2, Line 35: + flake8: W504 line break after binary operator -- To view, visit http://gerrit.cloudera.org:8080/24576 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I96aceda1b044ae53d09e68cb78678fc2930326dd Gerrit-Change-Number: 24576 Gerrit-PatchSet: 2 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Wed, 22 Jul 2026 13:18:40 +0000 Gerrit-HasComments: Yes
