Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24576 )
Change subject: IMPALA-15174: Add AGGREGATED_PROFILE query option to toggle profile formats ...................................................................... Patch Set 3: (2 comments) lgtm, only one final question needs to be resolved http://gerrit.cloudera.org:8080/#/c/24576/2/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/24576/2/be/src/service/impala-server.cc@2186 PS2, Line 2186: CLEAN_EXIT_WITH_ERROR(Substitute("Invalid default query options. Please > Yes, as an important option, it might be worth it to have an extra flag lik ok, the flag can stay from now, maybe we can deprecate and remove it once aggregated profile usage becomes the norm http://gerrit.cloudera.org:8080/#/c/24576/2/be/src/util/impala-profile-tool.cc File be/src/util/impala-profile-tool.cc: http://gerrit.cloudera.org:8080/#/c/24576/2/be/src/util/impala-profile-tool.cc@a138 PS2, Line 138: > I noticed that profile_version didn't seem to be used anywhere meaningfully I think that it is important to have easily accessable information in a profile whether it is aggregated or not. Even if tools don't use it yet, in the future they may For this specific case: removing this seems to cause using DEFAULT verbosity instead of LEGACY in case of old profile. Does this change the output for existing profiles? -- To view, visit http://gerrit.cloudera.org:8080/24576 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I96aceda1b044ae53d09e68cb78678fc2930326dd Gerrit-Change-Number: 24576 Gerrit-PatchSet: 3 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Mon, 27 Jul 2026 08:56:50 +0000 Gerrit-HasComments: Yes
