Mihaly Szjatinya has posted comments on this change. ( http://gerrit.cloudera.org:8080/24579 )
Change subject: IMPALA-15139: Support DELTA_LENGTH_BYTE_ARRAY Parquet encoding ...................................................................... Patch Set 7: (3 comments) Thanks for review. Also added a .gitignore for 'testdata/bin/minicluster_trino' http://gerrit.cloudera.org:8080/#/c/24579/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24579/5//COMMIT_MSG@40 PS5, Line 40: - tests > You could add a small interop test with Trino writing Parquet files, see ht Absoutely! Added explicit test_impala_reads_trino_parquet and renamed your test to test_impala_reads_trino_orc, if that's ok. Also after removing the Trino flag the tests in test_iceberg_trino_interop.py should involve the decoder as well. http://gerrit.cloudera.org:8080/#/c/24579/5/be/src/exec/parquet/parquet-delta-decoder.cc File be/src/exec/parquet/parquet-delta-decoder.cc: http://gerrit.cloudera.org:8080/#/c/24579/5/be/src/exec/parquet/parquet-delta-decoder.cc@56 PS5, Line 56: 0 > Add check that 'miniblocks_in_block != 0'. Ack http://gerrit.cloudera.org:8080/#/c/24579/5/be/src/exec/parquet/parquet-delta-length-byte-array-decoder.cc File be/src/exec/parquet/parquet-delta-length-byte-array-decoder.cc: http://gerrit.cloudera.org:8080/#/c/24579/5/be/src/exec/parquet/parquet-delta-length-byte-array-decoder.cc@47 PS5, Line 47: siz > You should use size_t instead, no need to narrow the type. Ack -- To view, visit http://gerrit.cloudera.org:8080/24579 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e4395fa30cd7fb2c89ef5a2b16b043d4de60b52 Gerrit-Change-Number: 24579 Gerrit-PatchSet: 7 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 23 Jul 2026 20:02:42 +0000 Gerrit-HasComments: Yes
