Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24579 )
Change subject: IMPALA-15139: Support DELTA_LENGTH_BYTE_ARRAY Parquet encoding ...................................................................... Patch Set 5: (4 comments) Thanks for working on this! http://gerrit.cloudera.org:8080/#/c/24579/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24579/5//COMMIT_MSG@40 PS5, Line 40: Testing You could add a small interop test with Trino writing Parquet files, see https://github.com/apache/impala/blob/6da4ba8a504ab725aa102cf5d424b1286be06243/tests/custom_cluster/test_trino_interop.py#L104 This could be also removed: https://github.com/apache/impala/blob/master/testdata/bin/minicluster_trino/session-property-config.json http://gerrit.cloudera.org:8080/#/c/24579/5/be/src/exec/parquet/parquet-column-readers.cc File be/src/exec/parquet/parquet-column-readers.cc: http://gerrit.cloudera.org:8080/#/c/24579/5/be/src/exec/parquet/parquet-column-readers.cc@470 PS5, Line 470: >= 0 Shouldn't it be '== num_values' to only return true if SkipValues can skip all values? http://gerrit.cloudera.org:8080/#/c/24579/5/be/src/exec/parquet/parquet-delta-decoder.cc File be/src/exec/parquet/parquet-delta-decoder.cc: http://gerrit.cloudera.org:8080/#/c/24579/5/be/src/exec/parquet/parquet-delta-decoder.cc@56 PS5, Line 56: miniblocks_in_block_ Add check that 'miniblocks_in_block != 0'. http://gerrit.cloudera.org:8080/#/c/24579/5/be/src/exec/parquet/parquet-delta-length-byte-array-decoder.cc File be/src/exec/parquet/parquet-delta-length-byte-array-decoder.cc: http://gerrit.cloudera.org:8080/#/c/24579/5/be/src/exec/parquet/parquet-delta-length-byte-array-decoder.cc@47 PS5, Line 47: int You should use size_t instead, no need to narrow the type. -- To view, visit http://gerrit.cloudera.org:8080/24579 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e4395fa30cd7fb2c89ef5a2b16b043d4de60b52 Gerrit-Change-Number: 24579 Gerrit-PatchSet: 5 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 20 Jul 2026 16:33:24 +0000 Gerrit-HasComments: Yes
