Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24576 )

Change subject: IMPALA-15174: Add AGGREGATED_PROFILE query option to toggle 
profile formats
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24576/2/be/src/util/runtime-profile.cc
File be/src/util/runtime-profile.cc:

http://gerrit.cloudera.org:8080/#/c/24576/2/be/src/util/runtime-profile.cc@a1628
PS2, Line 1628:
> > I noticed that profile_version didn't seem to be used anywhere meaningful
I see, I didn't understand this issue.
I think that we should still fill this field. Whether it is aggregated can be 
known easily, as there are 2 children of RuntimeProfileBase, 
AggregatedRuntimeProfile and RuntimeProfile



--
To view, visit http://gerrit.cloudera.org:8080/24576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I96aceda1b044ae53d09e68cb78678fc2930326dd
Gerrit-Change-Number: 24576
Gerrit-PatchSet: 2
Gerrit-Owner: Surya Hebbar <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Kurt Deschler <[email protected]>
Gerrit-Reviewer: Surya Hebbar <[email protected]>
Gerrit-Comment-Date: Mon, 27 Jul 2026 13:59:58 +0000
Gerrit-HasComments: Yes

Reply via email to