Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24570 )
Change subject: IMPALA-12675: Set PARQUET_ANNOTATE_STRINGS_UTF8 to true by default and turn on validation ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/24570/12/be/src/util/CMakeLists.txt File be/src/util/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/24570/12/be/src/util/CMakeLists.txt@141 PS12, Line 141: ${SIMDUTF_SRC_DIR}/simdutf.cpp) I think that it is not ideal to copy such large source code to Impala repo. Impala uses https://github.com/cloudera/native-toolchain to build 3rd party native dependencies, adding a new lib and downloading in Impala is not that hard. The main goal is to reduce compilation time and avoid unnecessary bloat in Impala repo. As we discussed offline, generating amalgated source that uses less functions we don't use could be also an option. -- To view, visit http://gerrit.cloudera.org:8080/24570 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia95bcba978863ffb5d603fdf81bb2c75ba06f7da Gerrit-Change-Number: 24570 Gerrit-PatchSet: 12 Gerrit-Owner: Daniel Vanko <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 27 Jul 2026 14:23:13 +0000 Gerrit-HasComments: Yes
