Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/24570 )
Change subject: IMPALA-12675: Set PARQUET_ANNOTATE_STRINGS_UTF8 to true by default and turn on validation ...................................................................... Patch Set 12: (2 comments) Thanks for working on this! Other than Csaba's comment about copying a large source code into Impala, I found this to be a really good patch! Just a couple of minor testing gaps. http://gerrit.cloudera.org:8080/#/c/24570/12/docs/topics/impala_incompatible_changes.xml File docs/topics/impala_incompatible_changes.xml: http://gerrit.cloudera.org:8080/#/c/24570/12/docs/topics/impala_incompatible_changes.xml@74 PS12, Line 74: CREATE TABLE AS : SELECT Can we have a test case exercising this path too. We are only checking for INSERT ... VALUES. http://gerrit.cloudera.org:8080/#/c/24570/12/docs/topics/impala_parquet_annotate_strings_utf8.xml File docs/topics/impala_parquet_annotate_strings_utf8.xml: http://gerrit.cloudera.org:8080/#/c/24570/12/docs/topics/impala_parquet_annotate_strings_utf8.xml@66 PS12, Line 66: <codeph>CHAR</codeph> and <codeph>VARCHAR</codeph> columns, : which are always annotated as UTF-8, are not validated Can we test this with something like: ``` CREATE TABLE t (c varchar(10)) STORED AS PARQUET; INSERT OVERWRITE t VALUES (unhex('ff')); -- should succeed -- assert column still has UTF8 converted_type ``` It'd confirm the documented asymmetry. -- To view, visit http://gerrit.cloudera.org:8080/24570 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia95bcba978863ffb5d603fdf81bb2c75ba06f7da Gerrit-Change-Number: 24570 Gerrit-PatchSet: 12 Gerrit-Owner: Daniel Vanko <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 28 Jul 2026 09:59:39 +0000 Gerrit-HasComments: Yes
