Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24601 )

Change subject: IMPALA-15193: ST_Intersects Incorrect Results Workaround
......................................................................


Patch Set 1:

(5 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/24601/1/java/hive-geospatial-functions/src/main/java/org/apache/impala/hive/geospatial/esri/ST_GeometryRelational.java
File 
java/hive-geospatial-functions/src/main/java/org/apache/impala/hive/geospatial/esri/ST_GeometryRelational.java:

http://gerrit.cloudera.org:8080/#/c/24601/1/java/hive-geospatial-functions/src/main/java/org/apache/impala/hive/geospatial/esri/ST_GeometryRelational.java@21
PS1, Line 21: import com.esri.core.geometry.Geometry;
unused import: com.esri.core.geometry.Geometry


http://gerrit.cloudera.org:8080/#/c/24601/1/java/hive-geospatial-functions/src/main/java/org/apache/impala/hive/geospatial/esri/ST_GeometryRelational.java@23
PS1, Line 23: import com.esri.core.geometry.OperatorIntersects;
unused import: com.esri.core.geometry.OperatorIntersects


http://gerrit.cloudera.org:8080/#/c/24601/1/java/hive-geospatial-functions/src/main/java/org/apache/impala/hive/geospatial/esri/ST_GeometryRelational.java@27
PS1, Line 27: import com.esri.core.geometry.ogc.OGCLineString;
unused import: com.esri.core.geometry.ogc.OGCLineString


http://gerrit.cloudera.org:8080/#/c/24601/1/java/hive-geospatial-functions/src/main/java/org/apache/impala/hive/geospatial/esri/ST_GeometryRelational.java@28
PS1, Line 28: import com.esri.core.geometry.ogc.OGCMultiLineString;
unused import: com.esri.core.geometry.ogc.OGCMultiLineString


http://gerrit.cloudera.org:8080/#/c/24601/1/java/hive-geospatial-functions/src/main/java/org/apache/impala/hive/geospatial/esri/ST_Intersects.java
File 
java/hive-geospatial-functions/src/main/java/org/apache/impala/hive/geospatial/esri/ST_Intersects.java:

http://gerrit.cloudera.org:8080/#/c/24601/1/java/hive-geospatial-functions/src/main/java/org/apache/impala/hive/geospatial/esri/ST_Intersects.java@20
PS1, Line 20: import com.esri.core.geometry.Geometry;
unused import: com.esri.core.geometry.Geometry



--
To view, visit http://gerrit.cloudera.org:8080/24601
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I62315574ca7cac2e71f3d301abbc9f0088b6533d
Gerrit-Change-Number: 24601
Gerrit-PatchSet: 1
Gerrit-Owner: Jason Fehr <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Comment-Date: Mon, 27 Jul 2026 23:36:54 +0000
Gerrit-HasComments: Yes

Reply via email to