Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24601 )
Change subject: IMPALA-15193: ST_Intersects Incorrect Results Workaround ...................................................................... Patch Set 1: Code-Review+1 (2 comments) lgtm, only nits http://gerrit.cloudera.org:8080/#/c/24601/1/java/hive-geospatial-functions/src/main/java/org/apache/impala/hive/geospatial/esri/ST_Intersects.java File java/hive-geospatial-functions/src/main/java/org/apache/impala/hive/geospatial/esri/ST_Intersects.java: http://gerrit.cloudera.org:8080/#/c/24601/1/java/hive-geospatial-functions/src/main/java/org/apache/impala/hive/geospatial/esri/ST_Intersects.java@51 PS1, Line 51: if (geom2 instanceof OGCMultiLineString) { Can you add a comment with the ticket and mention that the bug is asymmetric, so it would come if the fist arg is linestring, the second is multilinestring? http://gerrit.cloudera.org:8080/#/c/24601/1/testdata/workloads/functional-query/queries/QueryTest/geospatial-esri.test File testdata/workloads/functional-query/queries/QueryTest/geospatial-esri.test: http://gerrit.cloudera.org:8080/#/c/24601/1/testdata/workloads/functional-query/queries/QueryTest/geospatial-esri.test@2453 PS1, Line 2453: select ST_Intersects(st_geomfromtext('LINESTRING(1 0, 1 1)'), st_geomfromtext('MULTILINESTRING((0 0, 0 1), (2 0, 2 1))')); New tests usually go to geospatial-esri-extra.test, while this file contains tests that were generated from the test set of geospatial framework for hadoop Probably at this this distinction is not that useful though. -- To view, visit http://gerrit.cloudera.org:8080/24601 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I62315574ca7cac2e71f3d301abbc9f0088b6533d Gerrit-Change-Number: 24601 Gerrit-PatchSet: 1 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Comment-Date: Tue, 28 Jul 2026 09:05:16 +0000 Gerrit-HasComments: Yes
