Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23237 )
Change subject: IMPALA-14285: Add SAML2 authentication support for Coordinator Web UI ...................................................................... Patch Set 27: Code-Review+1 (5 comments) lgtm, just some minor comments http://gerrit.cloudera.org:8080/#/c/23237/27/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/23237/27/be/src/util/webserver.cc@564 PS27, Line 564: FLAGS_webserver_ldap_passwords_in_clear_ok Similarly to this we should normally reject starting up is saml is enable without tls. FLAGS_saml2_allow_without_tls_debug_only could be reused from hs2-http server to allow this during tests. http://gerrit.cloudera.org:8080/#/c/23237/27/be/src/util/webserver.cc@1037 PS27, Line 1037: host Do we need the host in this? My assumption is that it is either the Impala itself or something incorrect. We also use only the path part in hs2-http http://gerrit.cloudera.org:8080/#/c/23237/27/be/src/util/webserver.cc@1067 PS27, Line 1067: ";path=/" Why is the cooke generated with extra arg compared to other cases? Can you add a comment about that? http://gerrit.cloudera.org:8080/#/c/23237/27/fe/src/main/java/org/apache/impala/authentication/saml/HiveSamlRelayStateInfoHS2.java File fe/src/main/java/org/apache/impala/authentication/saml/HiveSamlRelayStateInfoHS2.java: http://gerrit.cloudera.org:8080/#/c/23237/27/fe/src/main/java/org/apache/impala/authentication/saml/HiveSamlRelayStateInfoHS2.java@20 PS27, Line 20: // copy of https://github.com/vihangk1/hive/blob/45863cc1fc94c2f2a848d0f3fc160a4dc0214747/service/src/java/org/apache/hive/service/auth/saml/HiveSamlRelayStateInfo.java > line too long (168 > 90) nit: this is no longer a copy http://gerrit.cloudera.org:8080/#/c/23237/27/fe/src/main/java/org/apache/impala/authentication/saml/HiveSamlRelayStateStoreHS2.java File fe/src/main/java/org/apache/impala/authentication/saml/HiveSamlRelayStateStoreHS2.java: http://gerrit.cloudera.org:8080/#/c/23237/27/fe/src/main/java/org/apache/impala/authentication/saml/HiveSamlRelayStateStoreHS2.java@24 PS27, Line 24: // slightly modified copy of https://github.com/vihangk1/hive/blob/45863cc1fc94c2f2a848d0f3fc160a4dc0214747/service/src/java/org/apache/hive/service/auth/saml/HiveSamlRelayStateInfo.java > line too long (186 > 90) "based on" would be better now -- To view, visit http://gerrit.cloudera.org:8080/23237 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12540300529f9c240abf7196141ecb0ae6e37995 Gerrit-Change-Number: 23237 Gerrit-PatchSet: 27 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Nandor Kollar <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 28 Jul 2026 18:12:00 +0000 Gerrit-HasComments: Yes
