Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24576 )
Change subject: IMPALA-15174: Add AGGREGATED_PROFILE query option to toggle profile formats ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/24576/8/be/src/util/impala-profile-tool.cc File be/src/util/impala-profile-tool.cc: http://gerrit.cloudera.org:8080/#/c/24576/8/be/src/util/impala-profile-tool.cc@173 PS8, Line 173: DCHECK(profile_type); : : if (*profile_type == "UNAGGREGATED") { : verbosity = RuntimeProfile::Verbosity::LEGACY; : } else { : verbosity = RuntimeProfile::Verbosity::DEFAULT; : } Though this area through a bit. impala-profile-tool benefits from being compatible with old profiles - I often do it this way, getting profiles from old released version and decoding with Impala at hand. For this reason I don't think that DCHECK fits here, and the default verbosity should be LEGACY to work with old profiles. New profiles should explicitly set their version. -- To view, visit http://gerrit.cloudera.org:8080/24576 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I96aceda1b044ae53d09e68cb78678fc2930326dd Gerrit-Change-Number: 24576 Gerrit-PatchSet: 8 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Mon, 03 Aug 2026 08:04:07 +0000 Gerrit-HasComments: Yes
