Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/24576 )
Change subject: IMPALA-15174: Add AGGREGATED_PROFILE query option to toggle profile formats ...................................................................... Patch Set 10: (2 comments) I have retained the previous tests and related profiles, along with testing the new updated format. Hope this fixes it, Thanks! http://gerrit.cloudera.org:8080/#/c/24576/9/be/src/util/impala-profile-tool.cc File be/src/util/impala-profile-tool.cc: http://gerrit.cloudera.org:8080/#/c/24576/9/be/src/util/impala-profile-tool.cc@173 PS9, Line 173: profile_type > != nullptr, we don't use raw ptrs in if()s in Impala Done http://gerrit.cloudera.org:8080/#/c/24576/9/testdata/impala-profiles/impala_profile_log_tpcds_compute_stats File testdata/impala-profiles/impala_profile_log_tpcds_compute_stats: http://gerrit.cloudera.org:8080/#/c/24576/9/testdata/impala-profiles/impala_profile_log_tpcds_compute_stats@1 PS9, Line 1: 1785722095212 5644dcaf9cc34cea:1147591800000000 eJyVVs9vG0UUnqSBhCRNmqh2d0kqphKHRGrC7ma99kbqwfhHYtEkxk5SCQnQeOfZGbo7487MJg23XlDUfwCQOMEBiRsnbhUX7ogTFyTEjSsc4IAoWq/dOGlSFR8sz3sz733ve9+bsRkat9+NQR7jJUbv5DzXpQFp+0Gw5gZA1m3bzed8u2D1P8uZMXM6OzK/MHIyX668vbeBt3bKFXyv2NiubW9EaaSuFG0WAg4kEA0UHx0kKxlzzngHE5webMUspFi0cS3qkpCs4j0FuFG5Wyk2K6lTYS1wBETFEvCDNDTItpAR4QGsmsYFEBZGHqMJZIw34ygi8jgzmsCdW7h+MlMSnEOQ4NlTIF9RsTwmUyUhJGWcaCFf71lW6hICppjgK7mcZ607ecuyJsvQJnGocbk1TtOfM2UIoUMG4dBEOZZEM8Eztu2u5nwnUnjJtt2c7+BYLU9UOMW7LIKbjuV4K1ZhxXKwXVjPueu53KpjO3aSx1rcZIfQBHkI0sF1KbQIRIj3QSaARve9+ZQrnPLc1ETDRLW2XWtuVsozfV9/9x7rLSk+TNc4t2qtWivN7WK9ubmz22/CUtqFtULg+wUI/MAJPNp2KYC7Vmi1gsB1fY+A41DHKRTs5dlt0EdC3sdFSiUoNWs7+STuqr2+5luea6XIdroJFQovKdC4dYwDwdus02cIE05xNyScg1xe3K1tVd7b2a7cKUYgWUDeuivUh0XegRDUmy8R7cURpi5iavrUGKvRnXcm0/XucReuNCu7k01QPcZq5Vs05zo+9Vzfdz3I5Zx1p5Br29AiNgB1acuaHmxOTk9t1vYrzUpjv9JwrjYfhGneCLgeT6CTMJxsaiL15Uqw/Hwun0zb2KlIzb+vD0E6k/CFehnK9Ux+z2Q6VPMwRxcI7Axb50TWQ3luss5NxnnFDM3SWYqGZ/GlGv+/tda7G8zbxlx6sCSiLgt728zqyU9/3vrnh6+877/83Xvyxy9Vc/ONLdCEEk2SO4qEIbawJq0QFA5IcAB0rshJeKyYwm3GmToAerMY6wMh2cdp6oEZL3Ehustz9QRGcgMOHMiY6XeBRRAyDmb150djv33610dPPv/2/jePvo7Mzdl0h4pbEdMa6PNRZhriSGFySFiYwLu2xyV0mNIg0zsTIWOiKgXXwGlmzFw0jMpDCGIt5IYUcVeVBFeMggSaQdlRlNyWV07mS0STUHRwIi4WQDILrbzvuTTwwLNtl7Tpuk/z4FGvHXh5AmuE3tiRrMM4CfFugmQgEoXmGtAGCTwAmroUMgvPGy87fwGYpJWXF4KMawMX7iQ+bGeQuWi8tgWRkMdb5GHm1ey/T/ufkV7NIyfj+yApC3ShqBTr8OTxaTOpdD9ECwISq8FDxBTmQmMSa7GiAtKj3jQGIXrwTrMhY6qearDG2yKD0jdp5GRgTaZwdlB832Yaw97+szadjl868RlkfmEYpZAB11XQwcFdEdy/R5hO5CQzk9kPkHF9yD3sevydQsbMdhwl4ul5e+1HyLhx1liVIiolek+9E416qSRirjMo+yoyphv1UgMIHYT99X1kXG3US/ck0zAw/vjJFWRkG+Joi2iQjIT9AWkQDZnRXs7nnYPDqNccZE4kDHx2abUX1nmuvssqe1bTmWrOlnEJ/MuA+7fPNGaAKLnrVMp+drT33evDwgboGq+GrHOg6+l/p+HdKIuGxJp9eqpbtJhBCP0H+J5F2Q== > Can we keep one of the profiles as the old one? Impala should be still able Done. I have retained the previous tests and related profiles now to make sure they are well tested and supported. -- To view, visit http://gerrit.cloudera.org:8080/24576 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I96aceda1b044ae53d09e68cb78678fc2930326dd Gerrit-Change-Number: 24576 Gerrit-PatchSet: 10 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Tue, 04 Aug 2026 07:41:22 +0000 Gerrit-HasComments: Yes
