Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10882 )
Change subject: IMPALA-7254: Inconsistent decimal behavior for IN/BETWEEN predicate ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/10882/3/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/10882/3/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@2286 PS3, Line 2286: Collections.sort(sortedExprs, new Comparator<Expr>() { It looks like we are sorting here in order to put the decimals at the end of the list. Do you think it would be simpler if we just did 2 passes over exprs instead (without creating a new list)? Where we handle the non-decimals in the first pass and the decimals in the second pass. http://gerrit.cloudera.org:8080/#/c/10882/3/fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java: http://gerrit.cloudera.org:8080/#/c/10882/3/fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java@2451 PS3, Line 2451: 2 as decimal(38, 37) One should be decimal(38,37) and the other one decimal(38,1) - to make sure that the decimals are not compatible with each other. Here and elsewhere. -- To view, visit http://gerrit.cloudera.org:8080/10882 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I44f6ea45f765be7201630541354c72fda0a8a98d Gerrit-Change-Number: 10882 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Comment-Date: Fri, 06 Jul 2018 23:25:31 +0000 Gerrit-HasComments: Yes
