Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10882 )
Change subject: IMPALA-7254: Inconsistent decimal behavior for IN/BETWEEN predicate ...................................................................... IMPALA-7254: Inconsistent decimal behavior for IN/BETWEEN predicate In decimal v2, performing a cast that can result in a loss of precision is considered as an error. In the prior code when finding a compatible type for performing a cast between expressions that have decimal and floating types can cause the decimal expressions to never be compared to other decimal expressions. This results in a cast to a type that may not be truly compatible in all expressions, especially when decimal v2 is enabled. This patch fixes it by grouping all the decimals together to make sure they are compatible with each other. Testing: - Added new FE tests - Ran all core tests Change-Id: I44f6ea45f765be7201630541354c72fda0a8a98d Reviewed-on: http://gerrit.cloudera.org:8080/10882 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M fe/src/main/java/org/apache/impala/analysis/Analyzer.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java 2 files changed, 97 insertions(+), 5 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/10882 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I44f6ea45f765be7201630541354c72fda0a8a98d Gerrit-Change-Number: 10882 Gerrit-PatchSet: 6 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]>
