Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24652 )
Change subject: IMPALA-15237: Add Calcite regression harness ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/24652/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java: http://gerrit.cloudera.org:8080/#/c/24652/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java@119 PS2, Line 119: @VisibleForTesting > I think it's better to move this into CalciteOptimizerTest and just make cr Fixed in PS3. createPreImpalaConvertPlan() is now package-private and @VisibleForTesting; the test result and metadata plumbing moved to CalciteOptimizerTest. http://gerrit.cloudera.org:8080/#/c/24652/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java@198 PS2, Line 198: static final class TestOptimizationResult { > Same comment as above, I think this can be moved into CalciteOptimizerTest Fixed in PS3. The result record and output metadata collection now live in CalciteOptimizerTest. http://gerrit.cloudera.org:8080/#/c/24652/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java@225 PS2, Line 225: private static final class PreImpalaConvertState { > I learned a neat Java 17 thing in a code review Fixed in PS3. PreImpalaConvertState is now a record, with plan() and simplifier() accessors. http://gerrit.cloudera.org:8080/#/c/24652/2/java/calcite-planner/src/test/java/org/apache/impala/calcite/service/CalciteOptimizerTest.java File java/calcite-planner/src/test/java/org/apache/impala/calcite/service/CalciteOptimizerTest.java: http://gerrit.cloudera.org:8080/#/c/24652/2/java/calcite-planner/src/test/java/org/apache/impala/calcite/service/CalciteOptimizerTest.java@138 PS2, Line 138: assertFalse(containsImpalaPlanRel(result.getPreImpalaConvertPlan())); > I'm ok with checking there is no ImpalaPlanRel, but it does seem a bit over Removed in PS3. The tests now exercise the narrow seam directly. http://gerrit.cloudera.org:8080/#/c/24652/2/java/calcite-planner/src/test/java/org/apache/impala/calcite/service/CalciteOptimizerTest.java@236 PS2, Line 236: private static boolean containsRelNodeFamily( > While this is better than what we currently have and I would approve this i Updated in PS3. The test now compares the exact ordered hierarchy (LogicalProject, LogicalTableScan) instead of generic family matches. -- To view, visit http://gerrit.cloudera.org:8080/24652 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8b0a1aca63b494d9c64fa6b8e33328bedce9c6b4 Gerrit-Change-Number: 24652 Gerrit-PatchSet: 2 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 03 Aug 2026 16:43:03 +0000 Gerrit-HasComments: Yes
