Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24652 )
Change subject: IMPALA-15237: Add Calcite regression harness ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/24652/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java: http://gerrit.cloudera.org:8080/#/c/24652/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java@91 PS3, Line 91: PreImpalaConvertState preImpalaConvertState = > Ok, sorry to make this correction now, but I just got to thinking... Fixed in PS4. createPreImpalaConvertPlan() now returns the RelNode directly. The final conversion no longer carries the simplifier, and runProgram() only sets the executor when one is provided. http://gerrit.cloudera.org:8080/#/c/24652/3/java/calcite-planner/src/test/java/org/apache/impala/calcite/service/CalciteOptimizerTest.java File java/calcite-planner/src/test/java/org/apache/impala/calcite/service/CalciteOptimizerTest.java: http://gerrit.cloudera.org:8080/#/c/24652/3/java/calcite-planner/src/test/java/org/apache/impala/calcite/service/CalciteOptimizerTest.java@140 PS3, Line 140: assertEquals(ImmutableList.of(LogicalProject.class, LogicalTableScan.class), > I suppose this is fine for now, but this is gonna get ugly for longer hiera Agreed. I left the current traversal assertion as-is in PS4. A branching-aware matcher can come with a Join/Union case when we need one. -- To view, visit http://gerrit.cloudera.org:8080/24652 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8b0a1aca63b494d9c64fa6b8e33328bedce9c6b4 Gerrit-Change-Number: 24652 Gerrit-PatchSet: 3 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 04 Aug 2026 03:14:14 +0000 Gerrit-HasComments: Yes
