Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10847 )
Change subject: IMPALA-6271: Impala daemon should log a message when it's being shut down ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/10847/2/be/src/service/impalad-main.cc File be/src/service/impalad-main.cc: http://gerrit.cloudera.org:8080/#/c/10847/2/be/src/service/impalad-main.cc@64 PS2, Line 64: LOG(INFO) << "SIGTERM encountered invoking default handler system going down" << endl; I would change the wording to "Caught SIGTERM. Daemon going down." http://gerrit.cloudera.org:8080/#/c/10847/2/be/src/service/impalad-main.cc@108 PS2, Line 108: old_action > Do we currently set a handler for SIGTERM elsewhere? If not, we should remo Please add a comment explaining why SIGTERM is specifically handled (i.e., we want to log a message when Impalad/statestored/catalogd is being shut down via the signal for whatever reason). -- To view, visit http://gerrit.cloudera.org:8080/10847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id20da9e30440b7348557beccb8a0da14775fcc29 Gerrit-Change-Number: 10847 Gerrit-PatchSet: 2 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Pranay Singh Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com> Gerrit-Comment-Date: Fri, 06 Jul 2018 23:56:02 +0000 Gerrit-HasComments: Yes
