Pranay Singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/10847 )
Change subject: IMPALA-6271: Impala daemon should log a message when it's being shut down ...................................................................... Patch Set 2: (9 comments) http://gerrit.cloudera.org:8080/#/c/10847/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10847/2//COMMIT_MSG@9 PS2, Line 9: Currently Impalad does not log any message when SIGTERM is sent to impalad > nit: flush left Done http://gerrit.cloudera.org:8080/#/c/10847/2//COMMIT_MSG@11 PS2, Line 11: recieved > nit: typo Done http://gerrit.cloudera.org:8080/#/c/10847/2//COMMIT_MSG@12 PS2, Line 12: shutdown > nit: two words Done http://gerrit.cloudera.org:8080/#/c/10847/2//COMMIT_MSG@14 PS2, Line 14: Testing: > This change should have an automatic test, possibly in custom-cluster-tests Done http://gerrit.cloudera.org:8080/#/c/10847/2/be/src/service/impalad-main.cc File be/src/service/impalad-main.cc: http://gerrit.cloudera.org:8080/#/c/10847/2/be/src/service/impalad-main.cc@62 PS2, Line 62: static void HandlerTerm(int signum) > nit: formatting ({ on same line). You can run clang-format with the config Done http://gerrit.cloudera.org:8080/#/c/10847/2/be/src/service/impalad-main.cc@64 PS2, Line 64: LOG(INFO) << "SIGTERM encountered invoking default handler system going down" << endl; > I would change the wording to "Caught SIGTERM. Daemon going down." Done http://gerrit.cloudera.org:8080/#/c/10847/2/be/src/service/impalad-main.cc@108 PS2, Line 108: old_action > Do we currently set a handler for SIGTERM elsewhere? If not, we should remo No we don't handle the SIGTERM elsewhere I have removed the old_action now I exit the process after handling SIGTERM http://gerrit.cloudera.org:8080/#/c/10847/2/be/src/service/impalad-main.cc@108 PS2, Line 108: old_action > Please add a comment explaining why SIGTERM is specifically handled (i.e., Done http://gerrit.cloudera.org:8080/#/c/10847/2/be/src/util/minidump.cc File be/src/util/minidump.cc: http://gerrit.cloudera.org:8080/#/c/10847/2/be/src/util/minidump.cc@101 PS2, Line 101: recieved > nit: typo Done -- To view, visit http://gerrit.cloudera.org:8080/10847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id20da9e30440b7348557beccb8a0da14775fcc29 Gerrit-Change-Number: 10847 Gerrit-PatchSet: 2 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Pranay Singh Gerrit-Reviewer: Zoram Thanga <[email protected]> Gerrit-Comment-Date: Wed, 11 Jul 2018 21:33:47 +0000 Gerrit-HasComments: Yes
