Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24534 )
Change subject: POC IMPALA-15161: Add GEOMETRY type for WKB_EXPERIMENTAL mode and make it defaul ...................................................................... Patch Set 10: (11 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24534/10/bin/start-impala-cluster.py File bin/start-impala-cluster.py: http://gerrit.cloudera.org:8080/#/c/24534/10/bin/start-impala-cluster.py@165 PS10, Line 165: ) flake8: E501 line too long (91 > 90 characters) http://gerrit.cloudera.org:8080/#/c/24534/10/fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java File fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java: http://gerrit.cloudera.org:8080/#/c/24534/10/fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java@88 PS10, Line 88: // Functions that take raw bytes and produce geometry (BINARY -> GEOMETRY in WKB mode). line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24534/10/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java: http://gerrit.cloudera.org:8080/#/c/24534/10/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@3358 PS10, Line 3358: if (t.isUuid() || t.isGeometry()) continue; // UUID is only supported for Iceberg tables. line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/24534/10/fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java: http://gerrit.cloudera.org:8080/#/c/24534/10/fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java@2357 PS10, Line 2357: // With WKB_EXPERIMENTAL as the default geospatial library, the geospatial builtins are line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24534/10/fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java@2377 PS10, Line 2377: // must still be wrapped since a top-level query cannot return GEOMETRY (IMPALA-15244). line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24534/10/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java: http://gerrit.cloudera.org:8080/#/c/24534/10/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@2502 PS10, Line 2502: // as non-numeric; count works. Unlike BINARY, GEOMETRY has no comparison operators, so line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24534/10/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@2503 PS10, Line 2503: // DISTINCT (which must hash/compare) is rejected, like VARIANT. st_point(...) produces line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24534/10/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@2528 PS10, Line 2528: "select count(distinct st_point(double_col, double_col)) from functional.alltypes", line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24534/10/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@2531 PS10, Line 2531: // VARIANT/complex types. The geometry is placed in the clause (not the output list) so line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24534/10/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@3627 PS10, Line 3627: // UNION ALL of geometry is allowed (no compare), but UNION/INTERSECT/EXCEPT (DISTINCT) line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24534/10/tests/query_test/test_geospatial_functions.py File tests/query_test/test_geospatial_functions.py: http://gerrit.cloudera.org:8080/#/c/24534/10/tests/query_test/test_geospatial_functions.py@44 PS10, Line 44: v flake8: U100 Unused argument 'vector' -- To view, visit http://gerrit.cloudera.org:8080/24534 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0ff29cb15ab45f3899bf453041e605a32f195c27 Gerrit-Change-Number: 24534 Gerrit-PatchSet: 10 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Tue, 04 Aug 2026 19:28:52 +0000 Gerrit-HasComments: Yes
