Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24534 )
Change subject: POC IMPALA-15161: Add GEOMETRY type for WKB_EXPERIMENTAL mode ...................................................................... Patch Set 9: (2 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24534/9/fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java File fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java: http://gerrit.cloudera.org:8080/#/c/24534/9/fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java@88 PS9, Line 88: // Functions that take raw bytes and produce geometry (BINARY -> GEOMETRY in WKB mode). line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24534/9/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java: http://gerrit.cloudera.org:8080/#/c/24534/9/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@3358 PS9, Line 3358: if (t.isUuid() || t.isGeometry()) continue; // UUID is only supported for Iceberg tables. line too long (96 > 90) -- To view, visit http://gerrit.cloudera.org:8080/24534 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0ff29cb15ab45f3899bf453041e605a32f195c27 Gerrit-Change-Number: 24534 Gerrit-PatchSet: 9 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Tue, 04 Aug 2026 15:06:06 +0000 Gerrit-HasComments: Yes
