Csaba Ringhofer has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/24661 )
Change subject: IMPALA-15247: Unify not-comparable type checks in Type.throwIfNotComparable ...................................................................... IMPALA-15247: Unify not-comparable type checks in Type.throwIfNotComparable Several analysis checks independently rejected complex/VARIANT types with their own ad-hoc error messages, e.g. ORDER BY, GROUP BY ... Consolidate them into Type.supportsComparison() and Type.throwIfNotComparable(exprDesc), which emit a single uniform message: "<exprDesc> with type '<type>' is not supported." This slightly changes some error messages. supportsComparison() also excludes UUID, which is not comparable until its builtins are implemented; UUID is now rejected consistently at these sites. Existing complex/VARIANT test messages are updated to the unified wording. This is a geometry-free refactor extracted from the adding GEOMETRY type: https://gerrit.cloudera.org/#/c/24534/ Change-Id: I2dc2c4579508cf1f8954ac251087c52f2eddf36a --- M fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java M fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java M fe/src/main/java/org/apache/impala/analysis/QueryStmt.java M fe/src/main/java/org/apache/impala/analysis/SelectStmt.java M fe/src/main/java/org/apache/impala/analysis/SetOperationStmt.java M fe/src/main/java/org/apache/impala/catalog/Type.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java M testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-variant.test M testdata/workloads/functional-query/queries/QueryTest/nested-array-in-select-list.test M testdata/workloads/functional-query/queries/QueryTest/nested-map-in-select-list.test M testdata/workloads/functional-query/queries/QueryTest/nested-struct-in-select-list.test M testdata/workloads/functional-query/queries/QueryTest/sort-complex.test M testdata/workloads/functional-query/queries/QueryTest/struct-in-select-list.test 14 files changed, 81 insertions(+), 81 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/24661/2 -- To view, visit http://gerrit.cloudera.org:8080/24661 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2dc2c4579508cf1f8954ac251087c52f2eddf36a Gerrit-Change-Number: 24661 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <[email protected]>
