Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/24661 )
Change subject: IMPALA-15247: Unify not-comparable type checks in Type.throwIfNotComparable ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/24661/3/fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java File fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java: http://gerrit.cloudera.org:8080/#/c/24661/3/fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java@262 PS3, Line 262: (complex, VARIANT and UUID) no need to mention now as the function call to throwIfNotComparable shows it http://gerrit.cloudera.org:8080/#/c/24661/3/fe/src/main/java/org/apache/impala/catalog/Type.java File fe/src/main/java/org/apache/impala/catalog/Type.java: http://gerrit.cloudera.org:8080/#/c/24661/3/fe/src/main/java/org/apache/impala/catalog/Type.java@292 PS3, Line 292: throwIfNotComparable The call sites asking for an overload that takes the SQL representation of the expression. Only "expr.getType().throwIfNotComparable("UNION, EXCEPT and INTERSECT")" uses it without string concats, maybe it's worth checking how it looks with a throwIfNotComparable(String exprDesc, String exprSql) implementation. -- To view, visit http://gerrit.cloudera.org:8080/24661 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2dc2c4579508cf1f8954ac251087c52f2eddf36a Gerrit-Change-Number: 24661 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Mon, 17 Aug 2026 14:52:22 +0000 Gerrit-HasComments: Yes
