Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24662 )

Change subject: IMPALA-15006: SHOW FILES does not list deletion vectors for 
Iceberg V3 tables
......................................................................


Patch Set 2:

(2 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/24662/2/common/thrift/CatalogObjects.thrift
File common/thrift/CatalogObjects.thrift:

http://gerrit.cloudera.org:8080/#/c/24662/2/common/thrift/CatalogObjects.thrift@671
PS2, Line 671: // Unified container for all Iceberg delete files (position 
deletes, DVs, equality deletes)
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/24662/2/fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java
File fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java:

http://gerrit.cloudera.org:8080/#/c/24662/2/fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java@279
PS2, Line 279:     /** DV metadata for a specific data file. For 
IcebergScanNode.applyDeletionVector(). */
line too long (91 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/24662
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica86830da6cc1eba335159612b73a905a339b064
Gerrit-Change-Number: 24662
Gerrit-PatchSet: 2
Gerrit-Owner: Nandor Kollar <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Nandor Kollar <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>
Gerrit-Comment-Date: Wed, 05 Aug 2026 08:58:23 +0000
Gerrit-HasComments: Yes

Reply via email to