Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24662 )
Change subject: IMPALA-15006: SHOW FILES does not list deletion vectors for Iceberg V3 tables ...................................................................... Patch Set 3: (8 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24662/3/common/thrift/CatalogObjects.thrift File common/thrift/CatalogObjects.thrift: http://gerrit.cloudera.org:8080/#/c/24662/3/common/thrift/CatalogObjects.thrift@671 PS3, Line 671: // Unified container for all Iceberg delete files (position deletes, DVs, equality deletes) line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24662/3/fe/src/main/java/org/apache/impala/analysis/AlterTableDropPartitionStmt.java File fe/src/main/java/org/apache/impala/analysis/AlterTableDropPartitionStmt.java: http://gerrit.cloudera.org:8080/#/c/24662/3/fe/src/main/java/org/apache/impala/analysis/AlterTableDropPartitionStmt.java@39 PS3, Line 39: import org.apache.impala.common.IcebergPartitionPredicateConverter; unused import: org.apache.impala.common.IcebergPartitionPredicateConverter http://gerrit.cloudera.org:8080/#/c/24662/3/fe/src/main/java/org/apache/impala/analysis/AlterTableDropPartitionStmt.java@40 PS3, Line 40: import org.apache.impala.common.IcebergPredicateConverter; unused import: org.apache.impala.common.IcebergPredicateConverter http://gerrit.cloudera.org:8080/#/c/24662/3/fe/src/main/java/org/apache/impala/analysis/AlterTableDropPartitionStmt.java@146 PS3, Line 146: List<Expression> icebergPartitionExprs = IcebergUtil.filterExprToIcebergExpr(table, partitionSet_.getPartitionExprs(), analyzer); line too long (133 > 90) http://gerrit.cloudera.org:8080/#/c/24662/3/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/24662/3/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@131 PS3, Line 131: List<Expression> icebergExprs = IcebergUtil.filterExprToIcebergExpr(this, filterExprs, analyzer); line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/24662/3/fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java File fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java: http://gerrit.cloudera.org:8080/#/c/24662/3/fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java@279 PS3, Line 279: /** DV metadata for a specific data file. For IcebergScanNode.applyDeletionVector(). */ line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24662/3/fe/src/main/java/org/apache/impala/util/IcebergUtil.java File fe/src/main/java/org/apache/impala/util/IcebergUtil.java: http://gerrit.cloudera.org:8080/#/c/24662/3/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@182 PS3, Line 182: * predicates that fail or only partially convert (which could match more than intended). line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24662/3/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@187 PS3, Line 187: new IcebergPartitionExpressionRewriter(analyzer, table.getIcebergApiTable().spec()); line too long (96 > 90) -- To view, visit http://gerrit.cloudera.org:8080/24662 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica86830da6cc1eba335159612b73a905a339b064 Gerrit-Change-Number: 24662 Gerrit-PatchSet: 3 Gerrit-Owner: Nandor Kollar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Nandor Kollar <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Wed, 05 Aug 2026 12:33:53 +0000 Gerrit-HasComments: Yes
