Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24657 )
Change subject: IMPALA-13534: Implement runtime filters on CTEs ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/24657/2/be/src/exec/cte-consumer-node.cc File be/src/exec/cte-consumer-node.cc: http://gerrit.cloudera.org:8080/#/c/24657/2/be/src/exec/cte-consumer-node.cc@140 PS2, Line 140: filter_ctx.filter = state->filter_bank()->RegisterConsumer(filter_desc); We also want to initialize stats. http://gerrit.cloudera.org:8080/#/c/24657/2/be/src/exec/cte-consumer-node.cc@241 PS2, Line 241: if (!filter_ctxs_.empty()) FilterRowBatch(output_batch); We need to wait for filters to arrive sometime after opening them but before using them. -- To view, visit http://gerrit.cloudera.org:8080/24657 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic877fb590187826f828da6a27bf274465c381e8e Gerrit-Change-Number: 24657 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 05 Aug 2026 16:52:43 +0000 Gerrit-HasComments: Yes
