Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24657 )
Change subject: IMPALA-13534: Implement runtime filters on CTEs ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/24657/2/be/src/exec/cte-consumer-node.cc File be/src/exec/cte-consumer-node.cc: http://gerrit.cloudera.org:8080/#/c/24657/2/be/src/exec/cte-consumer-node.cc@140 PS2, Line 140: FilterContext& filter_ctx = filter_ctxs_.back(); > We also want to initialize stats. Done http://gerrit.cloudera.org:8080/#/c/24657/2/be/src/exec/cte-consumer-node.cc@241 PS2, Line 241: CTEConsumerPlanNode::MaterializeBatchFn fn = codegend_materialize_batch_fn_.load(); > We need to wait for filters to arrive sometime after opening them but befor Done http://gerrit.cloudera.org:8080/#/c/24657/2/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java File fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java: http://gerrit.cloudera.org:8080/#/c/24657/2/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@1178 PS2, Line 1178: // join nodes in case we don't find a destination node in the left subtree. > I think this can visit the same producer more than once. DistributedPlanner Done. Q24 is an example of this. http://gerrit.cloudera.org:8080/#/c/24657/2/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@1448 PS2, Line 1448: /** Reverses the effect of a prior blockFiltersForCteProducer() call. */ > Should we finalize the filter here? A filter can have more than one target Good point. I've instead restricted filters so that we can only use filters within a CTE that were also produced in that CTE. The updated TPC-DS planner tests demonstrate the change. Q4 was an example where previously it only applied filter 0 to consumer 46, but now it applies to 5 consumers. -- To view, visit http://gerrit.cloudera.org:8080/24657 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic877fb590187826f828da6a27bf274465c381e8e Gerrit-Change-Number: 24657 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 05 Aug 2026 21:41:14 +0000 Gerrit-HasComments: Yes
