[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/24642 )
Change subject: IMPALA-15229: Derive the EC Policy column from file metadata, not RPCs ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/24642/1/fe/src/main/java/org/apache/impala/catalog/FeFsTable.java File fe/src/main/java/org/apache/impala/catalog/FeFsTable.java: http://gerrit.cloudera.org:8080/#/c/24642/1/fe/src/main/java/org/apache/impala/catalog/FeFsTable.java@747 PS1, Line 747: // Erasure-coded, but the policy id was not recorded: the descript > Can sawNonEc=true at this point? If so, we should probably return MIXED. Pl Done — good catch. The check also revealed an order dependence (an unknown-policy EC file seen before a plain file fell back to the RPC), so the loop now collects flags and decides MIXED order-independently. Added FeFsTableTest covering these cases. http://gerrit.cloudera.org:8080/#/c/24642/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java: http://gerrit.cloudera.org:8080/#/c/24642/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@371 PS1, Line 371: return result; : } catch (IOException e) { : throw new UncheckedIOException(e); : } : } : : /** : * Returns the name of the erasure coding policy with id 'policy > You could use computeIfAbsent() so concurrent callers of this method won't Done — also refreshes the snapshot once when an id is missing from it, so policies added to the NameNode later still resolve without per-path lookups. -- To view, visit http://gerrit.cloudera.org:8080/24642 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I35fc413c4a1f4730baab55406b13f5541f379707 Gerrit-Change-Number: 24642 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Sun, 09 Aug 2026 08:51:00 +0000 Gerrit-HasComments: Yes
