Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22094 )
Change subject: IMPALA-13533: Calcite CTE backend ...................................................................... Patch Set 59: (1 comment) http://gerrit.cloudera.org:8080/#/c/22094/59/be/src/exec/cte-producer-node.cc File be/src/exec/cte-producer-node.cc: http://gerrit.cloudera.org:8080/#/c/22094/59/be/src/exec/cte-producer-node.cc@96 PS59, Line 96: // It is safe to move child_batch into the exchanger even when needs_deep_copy is set > I have something that seems to work that identifies if the CTE contains nod Oh right, union doesn't happen because https://github.com/apache/calcite/blob/calcite-1.42.0/core/src/main/java/org/apache/calcite/rel/RelCommonExpressionBasicSuggester.java won't propose a CTE containing a union. I'll try to cover that case anyway. -- To view, visit http://gerrit.cloudera.org:8080/22094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48f16d495d4b37be97e6a913f0eb5b94d70e199a Gerrit-Change-Number: 22094 Gerrit-PatchSet: 59 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Wed, 12 Aug 2026 17:25:23 +0000 Gerrit-HasComments: Yes
