Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22094 )
Change subject: IMPALA-13533: Calcite CTE backend ...................................................................... Patch Set 59: (1 comment) http://gerrit.cloudera.org:8080/#/c/22094/59/be/src/exec/cte-producer-node.cc File be/src/exec/cte-producer-node.cc: http://gerrit.cloudera.org:8080/#/c/22094/59/be/src/exec/cte-producer-node.cc@96 PS59, Line 96: // It is safe to move child_batch into the exchanger even when needs_deep_copy is set > For a union with passthrough, the union node can return rows marked as need I have something that seems to work that identifies if the CTE contains nodes that require deep copy (currently hash joins or nested loop joins that ReturnsBuildData). There are two pieces I'd still like to understand: - do I also need union? I probably need to find a relevant example. - when I use DeepCopyTo, the call to Smallify seems to mess up the layout so that codegen for Q70/Q70a reads the wrong string values and gets a different result. If I reproduce DeepCopyTo without Smallify, it works fine, which is what I've done for the moment. I think this reflects another location where we should be checking IsSmall but currently aren't. -- To view, visit http://gerrit.cloudera.org:8080/22094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48f16d495d4b37be97e6a913f0eb5b94d70e199a Gerrit-Change-Number: 22094 Gerrit-PatchSet: 59 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Wed, 12 Aug 2026 17:09:50 +0000 Gerrit-HasComments: Yes
