Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/24448 )
Change subject: IMPALA-14799: Add oauth_servers support and tests ...................................................................... Patch Set 18: Code-Review+1 (6 comments) http://gerrit.cloudera.org:8080/#/c/24448/17/be/src/util/jwt-util.cc File be/src/util/jwt-util.cc: http://gerrit.cloudera.org:8080/#/c/24448/17/be/src/util/jwt-util.cc@1025 PS17, Line 1025: if (!decoded_token->decoded_jwt_.has_key_id()) { > Done Done http://gerrit.cloudera.org:8080/#/c/24448/17/be/src/util/jwt-util.cc@1030 PS17, Line 1030: } > Done Done http://gerrit.cloudera.org:8080/#/c/24448/17/be/src/util/oauth-servers-manager.h File be/src/util/oauth-servers-manager.h: http://gerrit.cloudera.org:8080/#/c/24448/17/be/src/util/oauth-servers-manager.h@38 PS17, Line 38: const std::string& token, std::string* u > Done. I removed the matched_server_idx_out parameter from both Authenticate Done http://gerrit.cloudera.org:8080/#/c/24448/17/be/src/util/oauth-servers-manager.cc File be/src/util/oauth-servers-manager.cc: http://gerrit.cloudera.org:8080/#/c/24448/17/be/src/util/oauth-servers-manager.cc@81 PS17, Line 81: server_idx).jwt_helper.Verify(decoded_token); : > Done. I updated the loop condition in Verify() to use next_idx < jwt_helper Done http://gerrit.cloudera.org:8080/#/c/24448/17/be/src/util/oauth-servers-manager.cc@108 PS17, Line 108: > Done Done http://gerrit.cloudera.org:8080/#/c/24448/17/be/src/util/oauth-servers-manager.cc@125 PS17, Line 125: : : > Done. This is an internal-only path, so I replaced the runtime condition wi Done -- To view, visit http://gerrit.cloudera.org:8080/24448 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib29ff36600406ba59c10f29d79cc632020f4a3f7 Gerrit-Change-Number: 24448 Gerrit-PatchSet: 18 Gerrit-Owner: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Comment-Date: Wed, 12 Aug 2026 22:03:23 +0000 Gerrit-HasComments: Yes
