Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/24448 )
Change subject: IMPALA-14799: Add oauth_servers support and tests ...................................................................... Patch Set 18: -Code-Review (2 comments) http://gerrit.cloudera.org:8080/#/c/24448/18/be/src/rpc/authentication.cc File be/src/rpc/authentication.cc: http://gerrit.cloudera.org:8080/#/c/24448/18/be/src/rpc/authentication.cc@a185 PS18, Line 185: : : : : > Should we say jwt_validate_signature DEPRECATED instead of removing? I provided direction to delete this flag because it's dangerous since it enables a huge security attack vector, and it was no longer used for testing. That being said, I realize now that this flag should be moved to the startup flags graveyard in global-flags.cc. If someone has specified this flag with a value of "true", I don't want Impala to fail to start. http://gerrit.cloudera.org:8080/#/c/24448/18/be/src/rpc/authentication.cc@a231 PS18, Line 231: : : : : : > Should we say oauth_jwt_validate_signature DEPRECATED instead of removing? See comment on jwt_validate_signature flag. This flag should also be moved to the startup flags graveyard. -- To view, visit http://gerrit.cloudera.org:8080/24448 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib29ff36600406ba59c10f29d79cc632020f4a3f7 Gerrit-Change-Number: 24448 Gerrit-PatchSet: 18 Gerrit-Owner: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 21 Aug 2026 15:34:26 +0000 Gerrit-HasComments: Yes
