Hello Steve Carlin, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24667
to look at the new patch set (#4).
Change subject: IMPALA-15237: Test Substrait export
......................................................................
IMPALA-15237: Test Substrait export
Add a test-only Isthmus compatibility spike at the logical seam before
Impala conversion. Cover Values and Project, a named read with Filter
and Project, scalar arithmetic, and typed failure for unsupported
relations. Verify client-visible root names, protobuf serialization and
parsing, schemas, field references, and relation and function
inventories.
Depend on substrait-java 0.100.0, the first stable release containing
the substrait-java#1065 fix for virtual table literal types
(substrait-java#1064). Keep the Surefire classpath tweaks the test
needs: pin protobuf-java 4.35.1 and exclude the AWS SDK bundle. Isthmus
stays test-scoped and out of impala-package.
Upstream issue:
https://github.com/substrait-io/substrait-java/issues/1064
Upstream fix, released in 0.100.0:
https://github.com/substrait-io/substrait-java/pull/1065
Testing:
- io.substrait:isthmus:0.100.0 and its transitive dependencies resolve
from Maven Central (mvn dependency:get)
- CalciteSubstraitCompatibilityTest passed against the local
0.98.0+PR-1065 build; the first run against 0.100.0 is the
gerrit-code-review-checks job on this patch set
- git diff --check
Change-Id: I359d6d6f88df63a7b0fdf7c6d541ec884602852f
Assisted-by: gpt-5.6-sol (OpenAI Codex), Claude Fable 5 (Anthropic)
---
M java/calcite-planner/pom.xml
A
java/calcite-planner/src/test/java/org/apache/impala/calcite/service/CalciteSubstraitCompatibilityTest.java
2 files changed, 428 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/24667/4
--
To view, visit http://gerrit.cloudera.org:8080/24667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I359d6d6f88df63a7b0fdf7c6d541ec884602852f
Gerrit-Change-Number: 24667
Gerrit-PatchSet: 4
Gerrit-Owner: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
