Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10888 )
Change subject: IMPALA-7260: Fix decimal binary predicates ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/10888/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java: http://gerrit.cloudera.org:8080/#/c/10888/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java@265 PS1, Line 265: AnalyzesOk("select cast(1 as decimal(38,37)) " + operator + " cast(2 as bigint)"); > add a comment explaining what this is trying to test. Done http://gerrit.cloudera.org:8080/#/c/10888/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java@2418 PS1, Line 2418: testDecimalExpr(decimal_5_5 + " + cast(1 as tinyint)", > these tests look more specific than the added ones since the return type is No we don't get lucky here. Arithmetic operations go through a different code path. http://gerrit.cloudera.org:8080/#/c/10888/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java@2496 PS1, Line 2496: public void TestDecimalFunctions() throws AnalysisException { > worth it to add cases here for non-binary predicates? I don't think so. This patch only affects the behavior of decimal binary predicates. -- To view, visit http://gerrit.cloudera.org:8080/10888 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icc442e84cdff74a376ba25bd9897b0b4df5cf0b4 Gerrit-Change-Number: 10888 Gerrit-PatchSet: 1 Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Mon, 09 Jul 2018 22:12:14 +0000 Gerrit-HasComments: Yes
