Taras Bobrovytsky has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10888 )
Change subject: IMPALA-7260: Fix decimal binary predicates ...................................................................... IMPALA-7260: Fix decimal binary predicates When casting the inputs to a function call, we would try to cast non decimal numbers to a specific decimal type even though this is not necessary. The specific decimal type would be calculated by looking at all the inputs. It was possible for this calculation to fail due to some decimal types being incompatible with each other. We solve the problem by casting the non-decimal numerical inputs to a generic getMinResolutionDecimal(). Testing: - Added some analysis tests. Change-Id: Icc442e84cdff74a376ba25bd9897b0b4df5cf0b4 --- M fe/src/main/java/org/apache/impala/analysis/Expr.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java 2 files changed, 18 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/10888/2 -- To view, visit http://gerrit.cloudera.org:8080/10888 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icc442e84cdff74a376ba25bd9897b0b4df5cf0b4 Gerrit-Change-Number: 10888 Gerrit-PatchSet: 2 Gerrit-Owner: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com>
